Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.16] fix: substring() with exceeding length #897

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Aug 23, 2024

Description

Backport of #893 for 1.16.

All changes are the same as in the original.

Related issues

closes #801

(cherry picked from commit 315b732)
Add a test case to verify that the function `substring()` can handle an exceeding length. If the given length is greater than the string then it returns the remaining characters from the start index.

(cherry picked from commit 9af6832)
If substring() is called with a given length that is greater than the string then it returns the remaining characters from the start index.

(cherry picked from commit 1f7478b)
@saig0 saig0 requested a review from megglos August 23, 2024 04:46
@saig0 saig0 changed the title [Backport 1.16 fix: substring() with exceeding length [Backport 1.16] fix: substring() with exceeding length Aug 23, 2024
@saig0
Copy link
Member Author

saig0 commented Aug 27, 2024

@megglos 🔔 friendly reminder: I need your approval to merge the backport PR. 🍪

Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saig0 saig0 merged commit 95d0c21 into 1.16 Aug 29, 2024
3 checks passed
@saig0 saig0 deleted the 801-backport-1_16 branch August 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants